codeant-ai-for-open-source[bot] commented on code in PR #43594: URL: https://github.com/apache/superset/pull/43594#discussion_r3873462806
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -14,6 +14,18 @@ Users can configure automated alerts and reports to send dashboards or charts to Alerts and reports are disabled by default. To turn them on, you'll need to change configuration settings and install a suitable headless browser in your environment. +## Content Format Options + +When scheduling an alert or report, you can choose the format used to deliver the dashboard or chart: + +- **PDF** – a full-page screenshot rendered as a PDF attachment. Available for both dashboards and charts. +- **PNG** – a screenshot embedded directly in the email or Slack message. Available for both dashboards and charts. Review Comment: **Suggestion:** The PNG is not embedded in the Slack message: Slack v2 uploads it as an external file and adds the report text as the initial comment. Describe Slack delivery as a file upload rather than inline embedding, and retain the inline-image description only for email. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Slack recipients receive uploaded PNG files. - ⚠️ Documentation incorrectly describes Slack image presentation. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6697caf8fbe94fadbeb00e12cb3fd900&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6697caf8fbe94fadbeb00e12cb3fd900&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/alerts-reports.mdx **Line:** 22:22 **Comment:** *Api Mismatch: The PNG is not embedded in the Slack message: Slack v2 uploads it as an external file and adds the report text as the initial comment. Describe Slack delivery as a file upload rather than inline embedding, and retain the inline-image description only for email. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43594&comment_hash=71e4a47a03ca9870baa85a582bab6032a3d07886cac9be8a2b8ee908baa9180e&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43594&comment_hash=71e4a47a03ca9870baa85a582bab6032a3d07886cac9be8a2b8ee908baa9180e&reaction=dislike'>👎</a> ########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -14,6 +14,18 @@ Users can configure automated alerts and reports to send dashboards or charts to Alerts and reports are disabled by default. To turn them on, you'll need to change configuration settings and install a suitable headless browser in your environment. +## Content Format Options + +When scheduling an alert or report, you can choose the format used to deliver the dashboard or chart: + +- **PDF** – a full-page screenshot rendered as a PDF attachment. Available for both dashboards and charts. +- **PNG** – a screenshot embedded directly in the email or Slack message. Available for both dashboards and charts. +- **CSV** – chart data attached as a `.csv` file. Available for charts only. +- **XLSX (Excel)** – chart data attached as a `.xlsx` file. Available for charts only. If the chart's data spans multiple server-paginated files, the attachment is delivered instead as a `.zip` archive containing the individual `.xlsx` files. Review Comment: **Suggestion:** The ZIP naming guarantee is not true for all delivery channels. Email detects a multi-file XLSX bundle and changes the extension to `.zip`, but Slack v2 always names the upload with an `.xlsx` suffix and webhook delivery uses `report.xlsx` unconditionally. Qualify this statement to email delivery or update those notification implementations to preserve the ZIP filename and content type. [type error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Slack bundles use an .xlsx filename despite ZIP contents. - ⚠️ Webhook bundles are always named report.xlsx. - ⚠️ Recipients may misidentify or mishandle multi-file exports. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d8aa4529f8f9458ca5bed9933a922267&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d8aa4529f8f9458ca5bed9933a922267&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/alerts-reports.mdx **Line:** 24:24 **Comment:** *Type Error: The ZIP naming guarantee is not true for all delivery channels. Email detects a multi-file XLSX bundle and changes the extension to `.zip`, but Slack v2 always names the upload with an `.xlsx` suffix and webhook delivery uses `report.xlsx` unconditionally. Qualify this statement to email delivery or update those notification implementations to preserve the ZIP filename and content type. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43594&comment_hash=d401d608d7c7c269a9fe704a13d5f58bf1742a68970230c18c3d233b88ac63bf&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43594&comment_hash=d401d608d7c7c269a9fe704a13d5f58bf1742a68970230c18c3d233b88ac63bf&reaction=dislike'>👎</a> ########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -14,6 +14,18 @@ Users can configure automated alerts and reports to send dashboards or charts to Alerts and reports are disabled by default. To turn them on, you'll need to change configuration settings and install a suitable headless browser in your environment. +## Content Format Options + +When scheduling an alert or report, you can choose the format used to deliver the dashboard or chart: + +- **PDF** – a full-page screenshot rendered as a PDF attachment. Available for both dashboards and charts. +- **PNG** – a screenshot embedded directly in the email or Slack message. Available for both dashboards and charts. +- **CSV** – chart data attached as a `.csv` file. Available for charts only. +- **XLSX (Excel)** – chart data attached as a `.xlsx` file. Available for charts only. If the chart's data spans multiple server-paginated files, the attachment is delivered instead as a `.zip` archive containing the individual `.xlsx` files. +- **Text** – chart data embedded directly in the email or Slack message body. Available only for charts using a text-based visualization type (e.g. Table, Pivot Table, Paired t-test). + +Dashboard reports and alerts are limited to the PDF and PNG formats; the CSV, XLSX, and Text options are only available when scheduling a report or alert for an individual chart. Review Comment: **Suggestion:** Chart CSV and XLSX alerts only produce their documented attachments when the `ALERTS_ATTACH_REPORTS` feature flag is enabled; without it, the execution path skips data generation and can send a notification without the attachment. Document this prerequisite alongside the format availability, or clarify that the options require this flag. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Chart alerts can omit requested CSV/XLSX attachments. - ⚠️ Administrators may misconfigure required alert-delivery settings. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=697a6a411e2d4d97b5ee70364425ab23&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=697a6a411e2d4d97b5ee70364425ab23&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/alerts-reports.mdx **Line:** 27:27 **Comment:** *Api Mismatch: Chart CSV and XLSX alerts only produce their documented attachments when the `ALERTS_ATTACH_REPORTS` feature flag is enabled; without it, the execution path skips data generation and can send a notification without the attachment. Document this prerequisite alongside the format availability, or clarify that the options require this flag. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43594&comment_hash=61c6607f5d8272bf0b9fe8f324d5a0631dcea7cabdaa868a12d2f3ef74a48ac7&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43594&comment_hash=61c6607f5d8272bf0b9fe8f324d5a0631dcea7cabdaa868a12d2f3ef74a48ac7&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
