rusackas commented on code in PR #43594:
URL: https://github.com/apache/superset/pull/43594#discussion_r3873822408


##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -14,6 +14,18 @@ Users can configure automated alerts and reports to send 
dashboards or charts to
 
 Alerts and reports are disabled by default. To turn them on, you'll need to 
change configuration settings and install a suitable headless browser in your 
environment.
 
+## Content Format Options
+
+When scheduling an alert or report, you can choose the format used to deliver 
the dashboard or chart:
+
+- **PDF** – a full-page screenshot rendered as a PDF attachment. Available for 
both dashboards and charts.
+- **PNG** – a screenshot embedded directly in the email or Slack message. 
Available for both dashboards and charts.

Review Comment:
   Confirmed — Slack v2 uses 
`files_getUploadURLExternal`/`files_completeUploadExternal`, an actual file 
upload with the report text as the initial comment, not an inline embed. Fixed 
to describe PNG delivery per channel.



##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -14,6 +14,18 @@ Users can configure automated alerts and reports to send 
dashboards or charts to
 
 Alerts and reports are disabled by default. To turn them on, you'll need to 
change configuration settings and install a suitable headless browser in your 
environment.
 
+## Content Format Options
+
+When scheduling an alert or report, you can choose the format used to deliver 
the dashboard or chart:
+
+- **PDF** – a full-page screenshot rendered as a PDF attachment. Available for 
both dashboards and charts.
+- **PNG** – a screenshot embedded directly in the email or Slack message. 
Available for both dashboards and charts.
+- **CSV** – chart data attached as a `.csv` file. Available for charts only.
+- **XLSX (Excel)** – chart data attached as a `.xlsx` file. Available for 
charts only. If the chart's data spans multiple server-paginated files, the 
attachment is delivered instead as a `.zip` archive containing the individual 
`.xlsx` files.

Review Comment:
   Right — Slack v2 and webhook always name the upload 
`<title>.xlsx`/`report.xlsx` even when the underlying bytes are a multi-file 
ZIP; only `email.py` sniffs the zip signature and renames to `.zip`. Qualified 
this to email delivery.



##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -14,6 +14,18 @@ Users can configure automated alerts and reports to send 
dashboards or charts to
 
 Alerts and reports are disabled by default. To turn them on, you'll need to 
change configuration settings and install a suitable headless browser in your 
environment.
 
+## Content Format Options
+
+When scheduling an alert or report, you can choose the format used to deliver 
the dashboard or chart:
+
+- **PDF** – a full-page screenshot rendered as a PDF attachment. Available for 
both dashboards and charts.
+- **PNG** – a screenshot embedded directly in the email or Slack message. 
Available for both dashboards and charts.
+- **CSV** – chart data attached as a `.csv` file. Available for charts only.
+- **XLSX (Excel)** – chart data attached as a `.xlsx` file. Available for 
charts only. If the chart's data spans multiple server-paginated files, the 
attachment is delivered instead as a `.zip` archive containing the individual 
`.xlsx` files.
+- **Text** – chart data embedded directly in the email or Slack message body. 
Available only for charts using a text-based visualization type (e.g. Table, 
Pivot Table, Paired t-test).
+
+Dashboard reports and alerts are limited to the PDF and PNG formats; the CSV, 
XLSX, and Text options are only available when scheduling a report or alert for 
an individual chart.

Review Comment:
   Confirmed in `execute.py:_get_notification_content` — for ALERT schedules 
the whole screenshot/CSV/XLSX generation block is gated on 
`ALERTS_ATTACH_REPORTS` (only REPORT schedules bypass the flag). Added a note 
on that prerequisite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to