bito-code-review[bot] commented on PR #43602:
URL: https://github.com/apache/superset/pull/43602#issuecomment-5441963336

   <!-- Bito Reply -->
   The flagged issue is correct. The documentation implies that 
`import_directory` supports the full range of assets found in a ZIP export, but 
the underlying implementation (using `ImportExamplesCommand`) is limited to 
specific asset types like databases, datasets, charts, and dashboards, 
excluding saved queries and tags.
   
   To resolve this, you should update the documentation to clarify the 
supported asset types. Here is the suggested update for 
`docs/admin_docs/configuration/importing-exporting-datasources.mdx`:
   
   ```markdown
   ## Importing a Directory of Assets
   
   The `import_directory` command imports a directory of exported assets 
(databases, datasets,
   dashboards, and charts) in the same layout produced by the ZIP-based export. 
Note that saved
   queries and tag files are not supported and will be ignored.
   
   ```bash
   superset import_directory <path / directory>
   ```
   ```
   
   There are no other comments on this PR to address.
   
   **docs/admin_docs/configuration/importing-exporting-datasources.mdx**
   ## Importing a Directory of Assets
   
   The `import_directory` command imports a directory of exported assets 
(databases, datasets,
   dashboards, and charts) in the same layout produced by the ZIP-based export. 
Note that saved
   queries and tag files are not supported and will be ignored.
   
   ```bash
   superset import_directory <path / directory>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to