codeant-ai-for-open-source[bot] commented on code in PR #43602: URL: https://github.com/apache/superset/pull/43602#discussion_r3873607108
########## docs/admin_docs/configuration/importing-exporting-datasources.mdx: ########## @@ -83,6 +83,25 @@ The optional username flag **-u** sets the user used for the datasource import. superset import_datasources -p <path / filename> -u 'admin' ``` +## Importing a Directory of Assets + +The `import_directory` command imports a directory of exported assets (databases, datasets, +dashboards, charts, etc.) in the same layout produced by the ZIP-based export: Review Comment: **Suggestion:** This wording implies that the directory command imports the complete ZIP-based asset export, but the implementation uses `ImportExamplesCommand`, whose schemas and import flow recognize only databases, datasets, charts, and dashboards. Saved-query files and exported tag files are not imported. Limit the documented asset types or document that those exported files are ignored. [incomplete implementation] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Saved queries from complete exports are silently omitted. - ⚠️ Standalone tag export data is not independently imported. - ⚠️ CLI results differ from complete API asset imports. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c23d3cf472dd4db085aef911af5e30d4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c23d3cf472dd4db085aef911af5e30d4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/importing-exporting-datasources.mdx **Line:** 88:89 **Comment:** *Incomplete Implementation: This wording implies that the directory command imports the complete ZIP-based asset export, but the implementation uses `ImportExamplesCommand`, whose schemas and import flow recognize only databases, datasets, charts, and dashboards. Saved-query files and exported tag files are not imported. Limit the documented asset types or document that those exported files are ignored. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43602&comment_hash=b7dea8154269c792e7e709d4e52de45ecddf63b45af57d32da6cfa8ae868d516&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43602&comment_hash=b7dea8154269c792e7e709d4e52de45ecddf63b45af57d32da6cfa8ae868d516&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
