codeant-ai-for-open-source[bot] commented on code in PR #43640: URL: https://github.com/apache/superset/pull/43640#discussion_r3878228050
########## requirements/development.in: ########## @@ -26,4 +26,9 @@ # including it here breaks the multi-platform (amd64+arm64) dev Docker # image build. The testcontainers CI job installs it on demand, only for # the db2 matrix leg -- see .github/workflows/testcontainers.yml. -testcontainers[cockroachdb,cratedb,db2,mssql,oracle,trino]>=4.15.0,<5 +# +# mariadb/timescaledb/yugabytedb need no testcontainers extra of their own: +# they reuse the postgres/mysql container classes pointed at a different +# image, and psycopg2-binary/mysqlclient are already pulled in above via +# the postgres/mysql extras. +testcontainers[cockroachdb,cratedb,db2,mongodb,mssql,mysql,oracle,postgres,trino]>=4.15.0,<5 Review Comment: **Suggestion:** The `db2` extra causes the baseline development installation to pull `ibm-db-sa`, contradicting the surrounding comment and the workflow's platform-compatibility rationale. Since `ibm-db-sa` has no Linux arm64 wheel, this breaks the multi-platform development image build that the comment says this requirement file must preserve. Remove `db2` from this baseline extra list and keep installing it only in the DB2 CI matrix leg. [possible bug] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ❌ Linux arm64 development image builds fail. - ❌ Baseline development dependency installation cannot complete. - ⚠️ DB2 CI coverage can use its dedicated installation. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=dbebfe4eceac416583d74fc45804eec7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=dbebfe4eceac416583d74fc45804eec7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** requirements/development.in **Line:** 34:34 **Comment:** *Possible Bug: The `db2` extra causes the baseline development installation to pull `ibm-db-sa`, contradicting the surrounding comment and the workflow's platform-compatibility rationale. Since `ibm-db-sa` has no Linux arm64 wheel, this breaks the multi-platform development image build that the comment says this requirement file must preserve. Remove `db2` from this baseline extra list and keep installing it only in the DB2 CI matrix leg. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43640&comment_hash=e4f7aca871e23d2daf98adbea1309ebbd071fa49cbb974365d57836d550fbe2a&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43640&comment_hash=e4f7aca871e23d2daf98adbea1309ebbd071fa49cbb974365d57836d550fbe2a&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
