rusackas commented on code in PR #43640:
URL: https://github.com/apache/superset/pull/43640#discussion_r3884844447
##########
pyproject.toml:
##########
@@ -270,13 +275,19 @@ tdengine = [
"taos-ws-py>=0.7.0"
]
teradata = ["teradatasql>=20.0.0.66"]
+# TimescaleDB is a genuine Postgres extension, not a fork - connects via the
+# plain postgresql dialect, same driver as postgres.
+timescaledb = ["apache-superset[postgres]"]
thumbnails = [] # deprecated, will be removed in 7.0
vertica = ["sqlalchemy-vertica-python>= 0.6.3, < 0.7"]
netezza = ["nzalchemy>= 11.1.2, < 11.2"]
starrocks = ["starrocks>=1.3.4, <2"]
doris = ["pydoris>=1.2.0, <2.0.0"]
oceanbase = ["oceanbase_py>=0.0.1.2"]
ydb = ["ydb-sqlalchemy>=0.1.22", "ydb-sqlglot-plugin>=0.2.8"]
+# YugabyteDB's YSQL layer is fully Postgres-wire compatible - connects via
+# the plain postgresql dialect, same driver as postgres.
+yugabytedb = ["apache-superset[postgres]"]
Review Comment:
Fair question. yugabytedb already diverges from plain postgres in the engine
spec itself, `_extended_aggregations` is disabled since
MEDIAN/STDDEV_SAMP/VAR_SAMP are unverified against its distributed query
engine, and the container needed its own readiness check since the image
doesn't ship psql. Feels worth keeping its own coverage rather than folding it
into postgres. Also each dialect is its own parallel job gated to paths that
touch this suite, so the added runner cost is bounded rather than additive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
