codeant-ai-for-open-source[bot] commented on code in PR #39657:
URL: https://github.com/apache/superset/pull/39657#discussion_r3880073480
##########
superset-frontend/src/dashboard/components/ColorSchemeSelect.tsx:
##########
@@ -189,7 +189,7 @@ const ColorSchemeSelect = ({
placeholder={t('Select scheme')}
value={currentScheme}
showSearch
- getPopupContainer={triggerNode => triggerNode.parentNode}
+ getPopupContainer={() => document.body}
Review Comment:
**Suggestion:** The dropdown is now mounted under `document.body`, outside
the element receiving the `css` prop. Consequently, the descendant selectors
for `.ant-select-item.ant-select-item-group` and
`.ant-select-item-option-grouped` no longer match the popup options, so grouped
color-scheme entries lose their intended padding and font styling. Move these
popup styles to a global/root-scoped rule or apply the styles directly to the
popup. [css layout issue]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Dashboard color-scheme groups lose custom padding.
- โ ๏ธ Grouped option typography reverts to default styling.
- โ ๏ธ StylingSection color selection remains functional but visually
inconsistent.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=aa8499514d084320912e665e9741253f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=aa8499514d084320912e665e9741253f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/components/ColorSchemeSelect.tsx
**Line:** 192:192
**Comment:**
*Css Layout Issue: The dropdown is now mounted under `document.body`,
outside the element receiving the `css` prop. Consequently, the descendant
selectors for `.ant-select-item.ant-select-item-group` and
`.ant-select-item-option-grouped` no longer match the popup options, so grouped
color-scheme entries lose their intended padding and font styling. Move these
popup styles to a global/root-scoped rule or apply the styles directly to the
popup.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39657&comment_hash=064be27d9c12e992ffd8e9cb4f12434e0c1f798f04062e63b0b59f160714682a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39657&comment_hash=064be27d9c12e992ffd8e9cb4f12434e0c1f798f04062e63b0b59f160714682a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
