7487 commented on code in PR #39657:
URL: https://github.com/apache/superset/pull/39657#discussion_r3901042075
##########
superset-frontend/src/dashboard/components/ColorSchemeSelect.tsx:
##########
@@ -189,7 +189,7 @@ const ColorSchemeSelect = ({
placeholder={t('Select scheme')}
value={currentScheme}
showSearch
- getPopupContainer={triggerNode => triggerNode.parentNode}
+ getPopupContainer={() => document.body}
Review Comment:
Confirmed — same root cause as the explore control: the old
`triggerNode.parentNode` container was the Select's own wrapper div, which is
where the compiled `css`-prop class lands, so these rules used to match and
broke with the body portal. Fixed in d7c71832 by attaching the grouped-option
rules to the popup root via `classNames.popup.root` (emotion `ClassNames`); the
new test in ColorSchemeControl.test.tsx covers the shared pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
