bito-code-review[bot] commented on PR #43668:
URL: https://github.com/apache/superset/pull/43668#issuecomment-5462475617
<!-- Bito Reply -->
Yes, the OceanBase install step should include the same gate as the test
step to prevent PR failures when the package is unavailable. Since the
`nightly_only` flag is defined in the matrix but cannot be referenced directly
in a job-level `if` condition, the install step should be updated to check the
matrix variable explicitly, similar to how the test step handles it.
**.github/workflows/testcontainers.yml**
```
- name: Install oceanbase driver (oceanbase_py)
if: matrix.dialect == 'oceanbase' && (github.event_name !=
'pull_request' || matrix.nightly_only != true)
run: uv pip install --system --no-deps "oceanbase_py>=0.0.1.2"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
