sadpandajoe commented on code in PR #43668:
URL: https://github.com/apache/superset/pull/43668#discussion_r3886608360
##########
.github/workflows/testcontainers.yml:
##########
@@ -116,6 +130,31 @@ jobs:
# instead, only for this leg of the matrix.
if: matrix.dialect == 'db2'
run: uv pip install --system -e .[db2]
+ - name: Install oceanbase driver (oceanbase_py)
+ # oceanbase_py pins sqlalchemy-utils>=0.38.3,<0.39, which conflicts
+ # outright with Superset's own sqlalchemy-utils==0.42.1 pin -- kept
+ # out of the baseline dev install for the same reason as db2 above.
+ # Installed as its own standalone package (not via `-e .[oceanbase]`)
+ # so --no-deps only skips *oceanbase_py's* dependencies -- applied
+ # to `-e .[oceanbase]` instead, --no-deps blocks pip from installing
+ # anything the extras marker pulls in, including oceanbase_py
+ # itself, which "succeeds" without actually installing it
+ # (confirmed on real CI: the install step reported success, but the
+ # module was still missing). This job only needs oceanbase_py's
+ # dialect module importable, not its sqlalchemy-utils dependency
+ # satisfied, since nothing here calls into it.
+ if: matrix.dialect == 'oceanbase'
Review Comment:
The `nightly_only` gate only skips the pytest step, so pull-request runs
still execute this OceanBase-only install before skipping the test. If the
unpinned package becomes unavailable or fails to install, a PR fails even
though this dialect is meant to run only nightly/manual. Should this condition
include the same event gate as the test step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
