Copilot commented on code in PR #43660:
URL: https://github.com/apache/superset/pull/43660#discussion_r3887840873
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -2882,3 +2882,49 @@ test('boundary label alignment is dropped when the
orientation moves the time ax
expect(horizontal.axisLabel.showMinLabel).toBe(true);
expect(horizontal.axisLabel.showMaxLabel).toBe(true);
});
+
+test('shows the value axis labels by default', () => {
+ const { echartOptions } = transformProps(createTestChartProps({}));
+ const { axisLabel } = echartOptions.yAxis as any;
Review Comment:
The added test block introduces several new `as any` casts (here and at
lines 2899, 2905, 2916, and 2929), which bypass type checking for the option
shape being asserted. Please define a small structural axis type containing
`axisLabel` visibility and `splitLine` fields, then use it for these casts, as
the existing formatter helper does at lines 101–103.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
