rusackas commented on code in PR #43660:
URL: https://github.com/apache/superset/pull/43660#discussion_r3890243998
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1335,9 +1336,9 @@ export default function transformProps(
minorSplitLine: { show: isSmallChart ? false : minorSplitLine },
splitLine: { show: isSmallChart ? false : gridlines },
axisLabel: {
- show: !isMicroChart,
- showMinLabel: !isMicroChart,
- showMaxLabel: !isMicroChart,
+ show: isMicroChart ? false : valueAxisLabels,
+ showMinLabel: isMicroChart ? false : valueAxisLabels,
+ showMaxLabel: isMicroChart ? false : valueAxisLabels,
Review Comment:
Hmm... I'd want to look more closely at what triggers isMicroChart, as this
may be a "surprise" to people that their axis labels disappeared, where a
control on the charts to "hide axis labels when small" (or some more
clever/terse wording) defaulting to the current value on existing charts (i.e.
null/false) would keep exisiting behavior on old charts, and new chat
instantiations could be "true" for the behavior you want, going forward. Then
we're not "breaking" data visualization for people in a surprising way on
today's charts and dashboardds. Curious what @dosu thinks of this approach, or
if I'm off base here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
