rusackas commented on code in PR #43054:
URL: https://github.com/apache/superset/pull/43054#discussion_r3890363814
##########
superset-frontend/eslint-rules/eslint-plugin-i18n-strings/index.ts:
##########
@@ -134,7 +134,8 @@ const plugin: { rules: Record<string, Rule.RuleModule> } = {
messageId: 'eager',
data: { property: keyName, fn: callee.callee.name },
fix(fixer) {
- const source = context.getSourceCode().getText(prop.value);
+ const sourceCode = context.sourceCode || context.getSourceCode();
+ const source = sourceCode.getText(prop.value);
Review Comment:
Good question, that one's gone now, the current head is back down to just
the plugin-scoping rename. Resolving.
##########
superset-frontend/src/pages/AlertReportList/AlertReportList.test.tsx:
##########
@@ -44,6 +45,23 @@ jest.mock('src/utils/getBootstrapData', () => ({
})),
}));
+// Mock withToasts HOC to inject default toast functions while preserving
explicit test spies passed via props
+jest.mock('src/components/MessageToasts/withToasts', () => ({
Review Comment:
Same story, not in the diff anymore, current head is scoped to just the
eslint plugin rename. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
