codeant-ai-for-open-source[bot] commented on code in PR #43698:
URL: https://github.com/apache/superset/pull/43698#discussion_r3890481767
##########
tests/unit_tests/db_engine_specs/test_drill.py:
##########
@@ -174,3 +174,22 @@ def test_connect_make_label_compatible(column_name: str,
expected_result: str) -
label = spec.make_label_compatible(column_name)
assert label == expected_result
+
+
+def test_drill_properties() -> None:
+ from superset.db_engine_specs.drill import DrillEngineSpec
+
+ assert DrillEngineSpec.engine == "drill"
+ assert DrillEngineSpec.engine_name == "Apache Drill"
+ assert DrillEngineSpec.default_driver == "sadrill"
+
+
+def test_drill_metadata() -> None:
+ from superset.db_engine_specs.drill import DrillEngineSpec
+
+ metadata = DrillEngineSpec.metadata
+ assert "Apache Drill" in metadata["description"]
+ assert metadata["logo"] == "drill.png"
Review Comment:
**Suggestion:** The test expects `drill.png`, but
`DrillEngineSpec.metadata["logo"]` is `apache-drill.png`, so this test always
fails. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c8c66cf337ff4011936fcd21c741c94e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c8c66cf337ff4011936fcd21c741c94e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_drill.py
**Line:** 192:192
**Comment:**
*Api Mismatch: The test expects `drill.png`, but
`DrillEngineSpec.metadata["logo"]` is `apache-drill.png`, so this test always
fails.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=9a88492a2950f44bc60775f0c3c91d5455dfb2148477d2f439348417a01d831a&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=9a88492a2950f44bc60775f0c3c91d5455dfb2148477d2f439348417a01d831a&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_firebird.py:
##########
@@ -104,3 +104,22 @@ def test_convert_dttm(
)
assert_convert_dttm(spec, target_type, expected_result, dttm)
+
+
+def test_firebird_properties() -> None:
+ from superset.db_engine_specs.firebird import FirebirdEngineSpec
+
+ assert FirebirdEngineSpec.engine == "firebird"
+ assert FirebirdEngineSpec.engine_name == "Firebird"
+ assert FirebirdEngineSpec.default_driver == "fdb"
Review Comment:
**Suggestion:** `FirebirdEngineSpec` does not define `default_driver` and
inherits `None`, so this assertion fails instead of validating a supported
driver. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4acc9df087344d7f9eec80f99153fe2a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4acc9df087344d7f9eec80f99153fe2a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_firebird.py
**Line:** 114:114
**Comment:**
*Api Mismatch: `FirebirdEngineSpec` does not define `default_driver`
and inherits `None`, so this assertion fails instead of validating a supported
driver.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=9abbc7f18aead902ef95359ba58836caf4d636503d3535c100231e91f6676c10&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=9abbc7f18aead902ef95359ba58836caf4d636503d3535c100231e91f6676c10&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_impala.py:
##########
@@ -172,3 +172,23 @@ def test_cancel_query_allows_internal_host_with_opt_out(
allow_redirects=False,
)
assert result is True
+
+
+def test_impala_properties() -> None:
+ from superset.db_engine_specs.impala import ImpalaEngineSpec
+
+ assert ImpalaEngineSpec.engine == "impala"
+ assert ImpalaEngineSpec.engine_name == "Apache Impala"
+ assert ImpalaEngineSpec.default_driver == "impala"
+ assert ImpalaEngineSpec.force_column_alias_quotes is True
+
+
+def test_impala_metadata() -> None:
+ from superset.db_engine_specs.impala import ImpalaEngineSpec
+
+ metadata = ImpalaEngineSpec.metadata
+ assert "Apache Impala" in metadata["description"]
+ assert metadata["logo"] == "impala.png"
Review Comment:
**Suggestion:** The test expects `impala.png`, but
`ImpalaEngineSpec.metadata["logo"]` is `apache-impala.png`, so this test always
fails. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ef06dd825e1f4c4e96d97b3d37089b9d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ef06dd825e1f4c4e96d97b3d37089b9d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_impala.py
**Line:** 191:191
**Comment:**
*Api Mismatch: The test expects `impala.png`, but
`ImpalaEngineSpec.metadata["logo"]` is `apache-impala.png`, so this test always
fails.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=e31b83e1bfc177678367f4d7d9abfe3e66ad0d1bb5c3daf2900b2d08b7a50256&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=e31b83e1bfc177678367f4d7d9abfe3e66ad0d1bb5c3daf2900b2d08b7a50256&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_impala.py:
##########
@@ -172,3 +172,23 @@ def test_cancel_query_allows_internal_host_with_opt_out(
allow_redirects=False,
)
assert result is True
+
+
+def test_impala_properties() -> None:
+ from superset.db_engine_specs.impala import ImpalaEngineSpec
+
+ assert ImpalaEngineSpec.engine == "impala"
+ assert ImpalaEngineSpec.engine_name == "Apache Impala"
+ assert ImpalaEngineSpec.default_driver == "impala"
Review Comment:
**Suggestion:** `ImpalaEngineSpec` does not define `default_driver` and
inherits `None`, so this new property assertion fails. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4d36845c8b72465f95687ad1500a012f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4d36845c8b72465f95687ad1500a012f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_impala.py
**Line:** 182:182
**Comment:**
*Api Mismatch: `ImpalaEngineSpec` does not define `default_driver` and
inherits `None`, so this new property assertion fails.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=4a34b58503e8f65c38e2999b441d9b884e7d54a0d4f3ddd02f5da8a1d6e7cc25&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=4a34b58503e8f65c38e2999b441d9b884e7d54a0d4f3ddd02f5da8a1d6e7cc25&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_hive.py:
##########
@@ -274,3 +274,23 @@ def test_spark_identifier_quote_uses_backticks() -> None:
"end": "`",
"escape_by_doubling": True,
}
+
+
+def test_hive_properties() -> None:
+ from superset.db_engine_specs.hive import HiveEngineSpec
+
+ assert HiveEngineSpec.engine == "hive"
+ assert HiveEngineSpec.engine_name == "Apache Hive"
+ assert HiveEngineSpec.default_driver == "pyhive"
+ assert HiveEngineSpec.max_column_name_length == 767
+
+
+def test_hive_metadata() -> None:
+ from superset.db_engine_specs.hive import HiveEngineSpec
+
+ metadata = HiveEngineSpec.metadata
+ assert "Apache Hive" in metadata["description"]
+ assert metadata["logo"] == "hive.png"
Review Comment:
**Suggestion:** Hive metadata uses `apache-hive.svg`, not `hive.png`, so
this newly added metadata test fails. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=acb31ba7f2e6444ca0c8233718d51419&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=acb31ba7f2e6444ca0c8233718d51419&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_hive.py
**Line:** 293:293
**Comment:**
*Api Mismatch: Hive metadata uses `apache-hive.svg`, not `hive.png`, so
this newly added metadata test fails.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=f372ffdad101c2a648cbc2c076cb202999d0748f8f1579974d0f6d24e154d206&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=f372ffdad101c2a648cbc2c076cb202999d0748f8f1579974d0f6d24e154d206&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_kusto.py:
##########
@@ -224,3 +224,27 @@ def test_kql_execute_array_processing(raw_query: str,
expected_query: str) -> No
KustoKqlEngineSpec.execute(mock_cursor, raw_query, mock_db)
mock_cursor.execute.assert_called_once_with(expected_query)
+
+
+def test_kusto_properties() -> None:
+ from superset.db_engine_specs.kusto import KustoKqlEngineSpec,
KustoSqlEngineSpec
+
+ assert KustoSqlEngineSpec.engine == "kustosql"
+ assert KustoSqlEngineSpec.engine_name == "Azure Data Explorer (Kusto SQL)"
Review Comment:
**Suggestion:** `KustoSqlEngineSpec.engine_name` is `Azure Data Explorer`,
so this assertion expects a name the class does not expose. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ce29c1abb8674b6fbb6fbe715b99d9cd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ce29c1abb8674b6fbb6fbe715b99d9cd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_kusto.py
**Line:** 233:233
**Comment:**
*Api Mismatch: `KustoSqlEngineSpec.engine_name` is `Azure Data
Explorer`, so this assertion expects a name the class does not expose.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=13d942c8ed1df68473e90d49cc2e6dfb5770f174d487925c15ea052c3d7eb06d&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=13d942c8ed1df68473e90d49cc2e6dfb5770f174d487925c15ea052c3d7eb06d&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_druid.py:
##########
@@ -258,3 +258,23 @@ def test_unmask_encrypted_extra() -> None:
assert DruidEngineSpec.unmask_encrypted_extra(old, new) == json.dumps(
{"connect_args": {"scheme": "http", "jwt": "old-token", "password":
"new"}}
)
+
+
+def test_druid_properties() -> None:
+ from superset.db_engine_specs.druid import DruidEngineSpec
+
+ assert DruidEngineSpec.engine == "druid"
+ assert DruidEngineSpec.engine_name == "Apache Druid"
+ assert DruidEngineSpec.allows_joins is True
+ assert DruidEngineSpec.allows_subqueries is True
Review Comment:
**Suggestion:** `allows_joins` follows the `DRUID_JOINS` feature flag, which
defaults to false, so this unconditional assertion fails in the default
configuration. [incorrect condition logic]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=96bb30bef55b48ef95e0e6cccd6e4346&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=96bb30bef55b48ef95e0e6cccd6e4346&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_druid.py
**Line:** 269:269
**Comment:**
*Incorrect Condition Logic: `allows_joins` follows the `DRUID_JOINS`
feature flag, which defaults to false, so this unconditional assertion fails in
the default configuration.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=5bb389a6d336c17619791cb980be2192941a1ca999697cdfe439a1751edc8a0a&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=5bb389a6d336c17619791cb980be2192941a1ca999697cdfe439a1751edc8a0a&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_druid.py:
##########
@@ -258,3 +258,23 @@ def test_unmask_encrypted_extra() -> None:
assert DruidEngineSpec.unmask_encrypted_extra(old, new) == json.dumps(
{"connect_args": {"scheme": "http", "jwt": "old-token", "password":
"new"}}
)
+
+
+def test_druid_properties() -> None:
+ from superset.db_engine_specs.druid import DruidEngineSpec
+
+ assert DruidEngineSpec.engine == "druid"
+ assert DruidEngineSpec.engine_name == "Apache Druid"
+ assert DruidEngineSpec.allows_joins is True
+ assert DruidEngineSpec.allows_subqueries is True
+
+
+def test_druid_metadata() -> None:
+ from superset.db_engine_specs.druid import DruidEngineSpec
+
+ metadata = DruidEngineSpec.metadata
+ assert "Apache Druid" in metadata["description"]
+ assert metadata["logo"] == "druid.png"
+ assert "pydruid" in metadata["pypi_packages"]
+ assert metadata["default_port"] == 8082
+
Review Comment:
**Suggestion:** The metadata declares port 9088, not 8082, so this assertion
fails whenever the test runs. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=25897a9b83264137bfc4404874ee508e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=25897a9b83264137bfc4404874ee508e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_druid.py
**Line:** 280:280
**Comment:**
*Api Mismatch: The metadata declares port 9088, not 8082, so this
assertion fails whenever the test runs.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=d8bc1e8bdbfc958d226ccf54fe2d9c0b802af6ec06e9bb575bb2517556fb3b4d&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=d8bc1e8bdbfc958d226ccf54fe2d9c0b802af6ec06e9bb575bb2517556fb3b4d&reaction=dislike'>馃憥</a>
##########
tests/unit_tests/db_engine_specs/test_kusto.py:
##########
@@ -224,3 +224,27 @@ def test_kql_execute_array_processing(raw_query: str,
expected_query: str) -> No
KustoKqlEngineSpec.execute(mock_cursor, raw_query, mock_db)
mock_cursor.execute.assert_called_once_with(expected_query)
+
+
+def test_kusto_properties() -> None:
+ from superset.db_engine_specs.kusto import KustoKqlEngineSpec,
KustoSqlEngineSpec
+
+ assert KustoSqlEngineSpec.engine == "kustosql"
+ assert KustoSqlEngineSpec.engine_name == "Azure Data Explorer (Kusto SQL)"
+ assert KustoKqlEngineSpec.engine == "kustokql"
+ assert KustoKqlEngineSpec.engine_name == "Azure Data Explorer (Kusto KQL)"
+
+
+def test_kusto_metadata() -> None:
+ from superset.db_engine_specs.kusto import KustoKqlEngineSpec,
KustoSqlEngineSpec
+
+ sql_meta = KustoSqlEngineSpec.metadata
+ assert "Azure Data Explorer" in sql_meta["description"]
+ assert sql_meta["logo"] == "azure.svg"
+ assert "sqlalchemy-kusto" in sql_meta["pypi_packages"]
+
+ kql_meta = KustoKqlEngineSpec.metadata
+ assert "Azure Data Explorer" in kql_meta["description"]
+ assert kql_meta["logo"] == "azure.svg"
Review Comment:
**Suggestion:** Both Kusto metadata objects use `kusto.png`, not
`azure.svg`, so these new logo assertions fail. [api mismatch]
**Assessment:** 馃煚 `Major` 路 馃攣 `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=80eedaa547884f1b942224a26f6bafdf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=80eedaa547884f1b942224a26f6bafdf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 馃 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_kusto.py
**Line:** 243:248
**Comment:**
*Api Mismatch: Both Kusto metadata objects use `kusto.png`, not
`azure.svg`, so these new logo assertions fail.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=562d9cc9212b795cdfd20e0defd2f6d66d0d1d9951fd135f9c9f57018e0198f1&reaction=like'>馃憤</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43698&comment_hash=562d9cc9212b795cdfd20e0defd2f6d66d0d1d9951fd135f9c9f57018e0198f1&reaction=dislike'>馃憥</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
