bito-code-review[bot] commented on code in PR #43698:
URL: https://github.com/apache/superset/pull/43698#discussion_r3890513883
##########
tests/unit_tests/db_engine_specs/test_druid.py:
##########
@@ -258,3 +258,23 @@ def test_unmask_encrypted_extra() -> None:
assert DruidEngineSpec.unmask_encrypted_extra(old, new) == json.dumps(
{"connect_args": {"scheme": "http", "jwt": "old-token", "password":
"new"}}
)
+
+
+def test_druid_properties() -> None:
+ from superset.db_engine_specs.druid import DruidEngineSpec
+
+ assert DruidEngineSpec.engine == "druid"
+ assert DruidEngineSpec.engine_name == "Apache Druid"
+ assert DruidEngineSpec.allows_joins is True
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Failing assertion</b></div>
<div id="fix">
`DruidEngineSpec.allows_joins` is set from
`is_feature_enabled("DRUID_JOINS")` (druid.py:48), and `DRUID_JOINS` defaults
to `False` in `config.py:905` with no test override. This assertion will fail
in CI. Assert `is False` (or patch the flag) to match actual behavior.
</div>
</div>
<small><i>Code Review Run #b696b7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
