endimonan commented on code in PR #43756:
URL: https://github.com/apache/superset/pull/43756#discussion_r3906978889
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -2658,6 +2659,74 @@ describe('plugin-chart-table', () => {
expect(screen.queryByText('Search by')).toBeInTheDocument();
});
+ test('defers server-side search until IME composition ends', async () => {
+ jest.useFakeTimers();
+ try {
+ const setDataMask = jest.fn();
+ const props = transformProps({
+ ...testData.raw,
+ rawFormData: {
+ ...testData.raw.rawFormData,
+ server_pagination: true,
+ include_search: true,
+ },
+ hooks: { setDataMask },
+ queriesData: [
+ {
+ ...testData.raw.queriesData[0],
+ colnames: ['name'],
+ coltypes: [GenericDataType.String],
+ data: [{ name: 'Michael' }, { name: 'John' }],
+ },
+ ],
+ });
+ render(
+ ProviderWrapper({
+ children: (
+ <TableChart {...props} setDataMask={setDataMask} sticky={false} />
+ ),
+ }),
+ );
+
+ const searchInput = screen.getByRole('textbox');
+ const searchCalls = () =>
+ setDataMask.mock.calls.filter(([mask]) =>
+ Object.prototype.hasOwnProperty.call(
+ mask?.ownState ?? {},
+ 'searchText',
+ ),
+ );
+
+ fireEvent.compositionStart(searchInput);
+ fireEvent.change(searchInput, { target: { value: 'nihao' } });
+
+ await act(async () => {
+ jest.advanceTimersByTime(300);
+ });
+ await act(async () => {
+ jest.advanceTimersByTime(900);
+ });
+ expect(searchInput).toHaveValue('nihao');
+ expect(searchCalls()).toHaveLength(0);
+
+ fireEvent.change(searchInput, { target: { value: '你好' } });
+ fireEvent.compositionEnd(searchInput);
Review Comment:
Good catch mate, thanks for reviewing. I added the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
