endimonan commented on code in PR #43756:
URL: https://github.com/apache/superset/pull/43756#discussion_r3907136663
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx:
##########
@@ -118,6 +129,17 @@ export default (memo as <T>(fn: T) => T)(function
GlobalFilter<
isSearchFocused.set(id, false);
};
+ const handleCompositionStart = () => {
+ isComposingRef.current = true;
Review Comment:
Good point. I now clear the composing flag on blur and added a regression
test confirming that search recovers after an interrupted composition.
Addressed in
https://github.com/apache/superset/pull/43756/commits/cac2444159ce6184237e931565525257711c347e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
