sadpandajoe commented on code in PR #43502:
URL: https://github.com/apache/superset/pull/43502#discussion_r3910113198
##########
superset/db_engine_specs/cockroachdb.py:
##########
@@ -44,7 +44,10 @@ class CockroachDbEngineSpec(PostgresEngineSpec):
DatabaseCategory.TRADITIONAL_RDBMS,
DatabaseCategory.OPEN_SOURCE,
],
- "pypi_packages": ["sqlalchemy-cockroachdb", "psycopg2"],
+ # sqlalchemy-cockroachdb declares no DBAPI dependency of its own (see
+ # the comment on the `cockroachdb` extra in pyproject.toml), so a
+ # plain `cockroachdb://` URL also needs psycopg2 installed to connect.
+ "pypi_packages": ["sqlalchemy-cockroachdb", "psycopg2-binary"],
Review Comment:
The generated database documentation still lists only the obsolete
`cockroachdb` package in `docs/src/data/databases.json`, so operators following
the rendered CockroachDB setup will install the incompatible dialect instead of
these required packages. Could this regenerate that artifact with
`sqlalchemy-cockroachdb` and `psycopg2-binary`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
