sadpandajoe commented on code in PR #43502:
URL: https://github.com/apache/superset/pull/43502#discussion_r3910126201
##########
pyproject.toml:
##########
@@ -271,18 +275,28 @@ tdengine = [
"taos-ws-py>=0.7.0"
]
teradata = ["teradatasql>=20.0.0.66"]
+# TimescaleDB is a genuine Postgres extension, not a fork - connects via the
+# plain postgresql dialect, same driver as postgres.
+timescaledb = ["apache-superset[postgres]"]
thumbnails = [] # deprecated, will be removed in 7.0
vertica = ["sqlalchemy-vertica-python>= 0.6.3, < 0.7"]
netezza = ["nzalchemy>= 11.1.2, < 11.2"]
starrocks = ["starrocks>=1.3.4, <2"]
doris = ["pydoris>=1.2.0, <2.0.0"]
oceanbase = ["oceanbase_py>=0.0.1.2"]
Review Comment:
The new `oceanbase` extra cannot be installed: Superset requires SQLAlchemy
2 and `sqlalchemy-utils>=0.42.1`, while `oceanbase_py` requires SQLAlchemy <2
and `sqlalchemy-utils<0.39`. The CI leg bypasses those dependencies with
`--no-deps`, but users installing `apache-superset[oceanbase]` get an
unsatisfiable environment. Could this remove or mark the unsupported extra
rather than publishing an installation path that cannot resolve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
