ShauryaaIBM commented on PR #43762: URL: https://github.com/apache/superset/pull/43762#issuecomment-5505183222
Addressed all CI failures in latest commit (a08aed89f5): 1. check-python-deps — pypdf==6.16.2 was missing from requirements/development.txt even though it was already pinned in requirements/base.txt and declared in pyproject.toml. Added the entry so the locked dev deps match. 2. lint-frontend / TSC — FeatureFlag.MobileConsumptionMode was referenced in PageHeaderWithActions/index.tsx but the enum entry was missing from superset-ui-core/src/utils/featureFlags.ts. Added MobileConsumptionMode = 'MOBILE_CONSUMPTION_MODE' to the enum. This was causing TS2339 to propagate across every package in the monorepo. 3. sharded-jest-tests (4) — Row.test.tsx — The new tests for FORCE_IN_VIEW_EVENT and RESTORE_VIRTUALIZATION_EVENT were added to Row.test.tsx but the corresponding window event listeners were never wired up in Row.tsx. Added handleForceInView and handleRestoreVirtualization listeners inside the virtualization useEffect, which disconnect/reconnect the IntersectionObservers as the tests expect. 4. sharded-jest-tests (8) — constants.test.ts — The new test asserts that RESERVED_CHART_URL_PARAMS contains permalink_key, but it was never added to that list. Added URL_PARAMS.permalinkKey.name to RESERVED_CHART_URL_PARAMS. 5. Playwright failures — Docker pull timeouts (dial tcp ... i/o timeout) on the CI runner. These are infrastructure-level failures unrelated to this PR's code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
