sadpandajoe commented on code in PR #43762:
URL: https://github.com/apache/superset/pull/43762#discussion_r3928820536
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -985,6 +1071,18 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
extra: contentType === ContentType.Dashboard ? currentAlert?.extra : {},
};
+ // Strip retry fields from the payload when the feature flag is off so
+ // that users cannot silently configure a retry policy the server will
+ // discard. When the flag is enabled the error-handling UI panel is
+ // shown and the user controls those fields explicitly.
+ if (!isFeatureEnabled(FeatureFlag.AlertReportsRetry)) {
Review Comment:
`AlertReportsRetry` was removed from `FeatureFlag`, but this new guard (and
the error-handling panel) still references it. The frontend build will fail
before the report modal can load; can we keep the existing enum member while
adding the browser-print flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
