sadpandajoe commented on code in PR #40679:
URL: https://github.com/apache/superset/pull/40679#discussion_r3911842816


##########
examples/asset_metadata_translation/README.md:
##########
@@ -0,0 +1,86 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Reference: database-backed asset metadata translation
+
+This is a **self-contained reference**, not part of Superset core. It shows one
+concrete way to implement end-to-end authoring on top of the
+`TRANSLATION_HOOK` read path documented at
+[Asset Metadata 
Translation](https://superset.apache.org/docs/configuration/asset-metadata-translation).

Review Comment:
   This link targets the old `/docs/configuration` route, but this page is 
served from the `admin-docs` plugin and the redirect list has no entry for this 
new slug, so readers of the example land on a 404. Could this point to 
`/admin-docs/configuration/asset-metadata-translation` (or add the redirect)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to