sadpandajoe commented on code in PR #40679:
URL: https://github.com/apache/superset/pull/40679#discussion_r3911897720
##########
superset/jinja_context.py:
##########
@@ -1105,6 +1105,7 @@ def set_context(self, **kwargs: Any) -> None:
"get_guest_user_attribute": partial(
safe_proxy, extra_cache.get_guest_user_attribute
),
+ "i18n": partial(safe_proxy, i18n_macro),
Review Comment:
This overwrites a deployment's existing `JINJA_CONTEXT_ADDONS["i18n"]` after
`BaseTemplateProcessor.set_context()` installs addons, even with the feature
disabled. Existing `{{ i18n(...) }}` templates therefore stop calling their
configured function after upgrade. Could the built-in only register when the
addon has not claimed this name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
