sadpandajoe commented on code in PR #43756:
URL: https://github.com/apache/superset/pull/43756#discussion_r3928545844
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx:
##########
@@ -116,6 +128,16 @@ export default (memo as <T>(fn: T) => T)(function
GlobalFilter<
const handleBlur = () => {
isSearchFocused.set(id, false);
+ isComposingRef.current = false;
Review Comment:
The added no-`compositionend` case blurs at 50ms, while the 200ms callback
is still pending. If that callback has already returned during composition,
`handleBlur` only clears the flag: the visible value is never applied to the
table. Could this replay the current value on that path and cover a delayed
blur without `compositionend`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
