EnxDev commented on PR #43820: URL: https://github.com/apache/superset/pull/43820#issuecomment-5540452376
Thanks for the detailed manual repros. All three cases are covered on the latest head: 1. The all-negative Column max case was fixed in 792a456896. A non-positive maximum makes percentage bounds fall back to the automatic data range, and the [-100, -5] / 0%-100% case has a regression test. 2. The mixed-sign Sum case is fixed in 2abe36b121. The denominator is now the sum of individual value magnitudes, so positive and negative values cannot cancel into a near-zero scale. The UI calls this Sum of magnitudes, the docs define it, and the exact [500, -499, 400, -400] shape is covered. Values below a configured 0% minimum remain transparent by design; a negative minimum or diverging scale should be used when negative values need distinct colors. 3. The control already rejected a center equal to either endpoint on blur or Apply. 2abe36b121 adds explicit tests for center == min and center == max and verifies that Apply is blocked with the corresponding validation message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
