EnxDev commented on PR #43820: URL: https://github.com/apache/superset/pull/43820#issuecomment-5540542722
@amaannawab923 thanks for re-testing against the newer head. The two remaining points are addressed on 61ae521c20: - Point 2 was fixed in 2abe36b121. Column sum now adds each value magnitude instead of taking the magnitude of the signed total, so 500 / -499 / 400 / -400 uses 1799 rather than 1 as its denominator. That exact shape has a regression test. With a configured minimum of 0%, negative values remain transparent by design; use a negative minimum or a diverging scale when they should receive distinct colors. - Point 3 is enforced in the control: a center equal to min or max is rejected on blur and Apply with a validation message. 2abe36b121 adds explicit center == min and center == max tests that verify Apply is blocked. 61ae521c20 also explains that a Column sum percentage center must resolve inside the color range; the runtime single-color fallback remains only as defense for imported or legacy invalid configurations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
