rusackas commented on PR #43236: URL: https://github.com/apache/superset/pull/43236#issuecomment-5548269517
@wuhyn thanks for the follow-ups, the WEEK and 11.1 answers both check out. One more thing before we merge, though. `IBMiEngineSpec` inherits `_time_grain_expressions` from `Db2EngineSpec`, and Db2 for i doesn't have `DATE_TRUNC` (it only has `TRUNC_TIMESTAMP`), so as-is this breaks every time grain for the IBM i connector. Easiest fix is probably to move the old arithmetic dict into `IBMiEngineSpec` as an override, with a parametrized test alongside the Db2 one. Also, if you're up for it, the 11.1 minimum would fit nicely in the `notes` of the Db2 `metadata` block, and a one-liner in UPDATING.md about WEEK now landing on Monday would save someone a surprise. Holler if you'd rather I push those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
