bito-code-review[bot] commented on PR #43870:
URL: https://github.com/apache/superset/pull/43870#issuecomment-5548877971
<!-- Bito Reply -->
The flagged issue is correct: the `PartitionPruningIndicator` was being
rendered in `OptionControlLabel` without verifying if the filter is actually
active or applicable to the current context.
To resolve this, you should ensure the indicator only renders when the
`partitionMapping` is valid and active. Since `OptionControlLabel` already
receives `partitionMapping` as a prop, you can update the component to check
for its existence before rendering the indicator.
### Proposed Fix
Update
`superset-frontend/src/explore/components/controls/OptionControls/index.tsx` to
conditionally render the indicator:
```tsx
// In OptionControlLabel component
{partitionMapping?.active && (
<PartitionPruningIndicator mapping={partitionMapping} />
)}
```
This ensures the glyph only appears when the mapping is active, preventing
misleading indicators for inactive or unrelated filters.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/src/explore/components/controls/OptionControls/index.tsx**
```
<PartitionPruningIndicator mapping={partitionMapping} />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
