codeant-ai-for-open-source[bot] commented on code in PR #43870:
URL: https://github.com/apache/superset/pull/43870#discussion_r3939218324
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -406,7 +408,12 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
{...props}
onDescriptionHoverChange={setIsDescriptionHovered}
/>
- {popoverContent}
+ {/* The glyph sits outside the popover trigger so clicking it opens the
+ tooltip rather than the time-range editor. */}
+ <Flex align="center" gap={theme.sizeUnit}>
+ {popoverContent}
+ <PartitionPruningIndicator mapping={props.partitionMapping} />
Review Comment:
**Suggestion:** The dataset-wide active mapping is shown without checking
the current time range or selected temporal column, so “No filter” and
unrelated columns display a glyph without a mirrored SQL predicate. [incorrect
condition logic]
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c99c992c1bf14a08888005aefa8e4fe6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c99c992c1bf14a08888005aefa8e4fe6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
**Line:** 415:415
**Comment:**
*Incorrect Condition Logic: The dataset-wide active mapping is shown
without checking the current time range or selected temporal column, so “No
filter” and unrelated columns display a glyph without a mirrored SQL predicate.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43870&comment_hash=16afe612b7a4b31306e20b232e495a267f63914e6590410afc8ffffbe445ccf8&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43870&comment_hash=16afe612b7a4b31306e20b232e495a267f63914e6590410afc8ffffbe445ccf8&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
