bikash-barnwal commented on PR #43193: URL: https://github.com/apache/superset/pull/43193#issuecomment-5550480870
You're right, thanks for tracing that through `axisTickLabelBuilder.js` — fixed the actual gap now. On a time axis, tick density comes from `minInterval`/`maxInterval` instead of `axisLabel.interval`. The previous commit only set `minInterval` to the resolved grain when a time grain existed, which just floors the spacing — ECharts can still choose a wider "nice" interval to fit the available width, so it wasn't actually forcing one label per point. Now when "All" is selected on a temporal axis with a resolved grain, both `minInterval` and `maxInterval` are pinned to that same grain value, which forces exactly one tick (and label) per data point. "All" wins over `forceMaxInterval`'s own (opposite) request, since the user explicitly asked to see every label. Without a resolved grain there's nothing to pin to, so that case keeps the pre-existing behavior (documented in a fallback test). Added a regression test using a temporal coltype + Day grain (mirroring the tooltip-time-grain tests' fixture pattern) asserting `minInterval`/`maxInterval` both equal the day-in-ms value and `hideOverlap` is still forced off, plus a test for the no-resolved-grain fallback. All 4 interval-related tests pass locally. Applied the same change to MixedTimeseries. Re: the rebase — I hit a shallow-clone issue attempting it locally (this fork's clone doesn't share full history with `apache/superset` master, so `git rebase` walked all the way back to a ~2015 root commit and conflicted there; I aborted before it did anything destructive). I don't have a safe way to fix that from here without a full unshallow fetch, so the branch is still showing conflicts against current master — flagging that honestly rather than leaving it unmentioned. Happy to redo the rebase with a proper full clone if useful, or if you'd rather just take this commit and resolve the merge conflict on your end, that works too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
