codeant-ai-for-open-source[bot] commented on code in PR #43193:
URL: https://github.com/apache/superset/pull/43193#discussion_r3939965287
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1204,6 +1205,26 @@ export default function transformProps(
xAxisType === AxisType.Time &&
xAxisLabelRotation === 0 &&
!!resolvedTimeGrain;
+ const {
+ interval: xAxisLabelIntervalValue,
+ showAllLabels: showAllXAxisLabels,
+ } = getAxisLabelInterval(xAxisLabelInterval);
+ // axisLabel.interval is only ever consulted for category axes in ECharts
+ // (axisTickLabelBuilder routes to makeCategoryLabels there; a time axis
+ // goes through makeRealNumberLabels and never reads it), and Superset sets
+ // xAxis.type to Time whenever the x-axis column is temporal -- the common
+ // case #36325 actually reports. On a time axis, tick density is governed
+ // by minInterval/maxInterval instead, and minInterval alone only floors
+ // the spacing: ECharts can still choose a wider "nice" interval to fit the
+ // available width. Pinning both bounds to the resolved grain forces one
+ // tick, and therefore one label, per data point.
+ const timeGrainIntervalMs = resolvedTimeGrain
+ ? (TIMEGRAIN_TO_TIMESTAMP[
+ resolvedTimeGrain as keyof typeof TIMEGRAIN_TO_TIMESTAMP
+ ] ?? undefined)
+ : undefined;
Review Comment:
**Suggestion:** Calendar grains use fixed durations, so pinning a month,
quarter, or year can create ticks on drifting dates and labels for missing time
periods. [logic error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f4d973040c224f5085f99c23080bd2f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f4d973040c224f5085f99c23080bd2f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
**Line:** 1221:1225
**Comment:**
*Logic Error: Calendar grains use fixed durations, so pinning a month,
quarter, or year can create ticks on drifting dates and labels for missing time
periods.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43193&comment_hash=34fe75cea44be601378d535594190511bf80f53f51e8c4e28c5360ff1d561b1f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43193&comment_hash=34fe75cea44be601378d535594190511bf80f53f51e8c4e28c5360ff1d561b1f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
