sadpandajoe commented on code in PR #43471:
URL: https://github.com/apache/superset/pull/43471#discussion_r3940338645
##########
superset/dashboards/api.py:
##########
@@ -357,17 +346,7 @@ class DashboardRestApi(
"purge": "write",
}
- # Default list_columns (used if config not set)
- list_columns = FULL_TAG_LIST_COLUMNS
-
- def __init__(self) -> None:
- # Configure custom tags optimization (mixin handles the logic)
- self._setup_custom_tags_optimization(
- config_key="DASHBOARD_LIST_CUSTOM_TAGS_ONLY",
- full_columns=FULL_TAG_LIST_COLUMNS,
- custom_columns=CUSTOM_TAG_LIST_COLUMNS,
- )
- super().__init__()
+ list_columns = TAG_LIST_COLUMNS
Review Comment:
An upgrade can retain implicit tag rows while this now always serializes the
unfiltered `Dashboard.tags` relationship. Deployments that had
`DASHBOARD_LIST_CUSTOM_TAGS_ONLY` enabled will therefore start returning those
legacy tags (and their old payload size) again, despite the release note saying
every returned tag is custom. Could we preserve the filtered list path until
legacy rows are gone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
