rusackas commented on code in PR #43471:
URL: https://github.com/apache/superset/pull/43471#discussion_r3940928804
##########
superset/dashboards/api.py:
##########
@@ -357,17 +346,7 @@ class DashboardRestApi(
"purge": "write",
}
- # Default list_columns (used if config not set)
- list_columns = FULL_TAG_LIST_COLUMNS
-
- def __init__(self) -> None:
- # Configure custom tags optimization (mixin handles the logic)
- self._setup_custom_tags_optimization(
- config_key="DASHBOARD_LIST_CUSTOM_TAGS_ONLY",
- full_columns=FULL_TAG_LIST_COLUMNS,
- custom_columns=CUSTOM_TAG_LIST_COLUMNS,
- )
- super().__init__()
+ list_columns = TAG_LIST_COLUMNS
Review Comment:
Good catch, fixed! Restored the custom_tags relationship, the
DASHBOARD_LIST_CUSTOM_TAGS_ONLY flag, and the mixin so deployments with legacy
implicit tags still get the filtered payload. Only the tag generation itself is
gone now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
