bito-code-review[bot] commented on PR #43898: URL: https://github.com/apache/superset/pull/43898#issuecomment-5549098104
<!-- Bito Reply --> The documentation currently states that `delete_chart` and `delete_dashboard` return `permission_denied` if the caller is not the owner or an Admin. If the actual implementation allows any user with edit rights to perform these deletions, the documentation should be updated to reflect that requirement instead of specifically mentioning ownership. You may want to clarify with the team whether the intended restriction is strictly ownership-based or if it encompasses broader edit permissions. **docs/docs/using-superset/using-ai-with-superset.mdx** ``` | `delete_chart` | Delete a chart by ID or UUID (soft-deletes to trash when `SOFT_DELETE` is enabled; returns `permission_denied` if the caller isn't owner/Admin) | | `delete_dashboard` | Delete a dashboard by ID, UUID, or slug; leaves its charts intact (soft-deletes to trash when `SOFT_DELETE` is enabled; returns `permission_denied` if the caller isn't owner/Admin) | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
