sadpandajoe commented on code in PR #43898:
URL: https://github.com/apache/superset/pull/43898#discussion_r3947172199
##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -269,26 +269,28 @@ Ask your admin for the MCP server URL and any
authentication tokens you need.
### Charts
-| Tool | Description
|
-| ----------------------- |
----------------------------------------------------------------------------------------------------------------------------------
|
-| `list_charts` | List charts with filtering and search
|
-| `get_chart_info` | Get chart metadata and configuration
|
-| `get_chart_data` | Retrieve chart data (JSON, CSV, or Excel)
|
-| `get_chart_preview` | Generate a chart preview (URL, ASCII, table, or
Vega-Lite)
|
-| `get_chart_type_schema` | Get the configuration schema for a chart type
|
-| `generate_chart` | Create a new chart from a specification (defaults
to preview mode — review before saving)
|
-| `update_chart` | Modify an existing chart's configuration (pass
`generate_preview=False` to persist immediately instead of returning a preview
URL) |
-| `update_chart_preview` | Update a cached chart preview without saving
|
-| `generate_explore_link` | Generate an Explore URL for interactive
visualization
|
+| Tool | Description
|
+| ----------------------- |
-------------------------------------------------------------------------------------------------------------------------------------------------
|
+| `list_charts` | List charts with filtering and search
|
+| `get_chart_info` | Get chart metadata and configuration
|
+| `get_chart_data` | Retrieve chart data (JSON, CSV, or Excel)
|
+| `get_chart_preview` | Generate a chart preview (URL, ASCII, table, or
Vega-Lite)
|
+| `get_chart_type_schema` | Get the configuration schema for a chart type
|
+| `generate_chart` | Create a new chart from a specification (defaults
to preview mode — review before saving)
|
+| `update_chart` | Modify an existing chart's configuration (pass
`generate_preview=False` to persist immediately instead of returning a preview
URL) |
+| `update_chart_preview` | Update a cached chart preview without saving
|
+| `generate_explore_link` | Generate an Explore URL for interactive
visualization
|
+| `delete_chart` | Delete a chart by ID or UUID (soft-deletes to
trash when `SOFT_DELETE` is enabled; returns `permission_denied` if the caller
isn't an editor of the chart — owners, Admins, and explicitly granted editors
qualify) |
Review Comment:
A user who can view but not edit a chart with an attached alert or report
reaches the reports check before editorship and receives `ReportsExist` with
`permission_denied=false`, so this response contract is not guaranteed. Could
this also describe the attached-report precondition rather than saying
non-editors receive `permission_denied`?
##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -269,26 +269,28 @@ Ask your admin for the MCP server URL and any
authentication tokens you need.
### Charts
-| Tool | Description
|
-| ----------------------- |
----------------------------------------------------------------------------------------------------------------------------------
|
-| `list_charts` | List charts with filtering and search
|
-| `get_chart_info` | Get chart metadata and configuration
|
-| `get_chart_data` | Retrieve chart data (JSON, CSV, or Excel)
|
-| `get_chart_preview` | Generate a chart preview (URL, ASCII, table, or
Vega-Lite)
|
-| `get_chart_type_schema` | Get the configuration schema for a chart type
|
-| `generate_chart` | Create a new chart from a specification (defaults
to preview mode — review before saving)
|
-| `update_chart` | Modify an existing chart's configuration (pass
`generate_preview=False` to persist immediately instead of returning a preview
URL) |
-| `update_chart_preview` | Update a cached chart preview without saving
|
-| `generate_explore_link` | Generate an Explore URL for interactive
visualization
|
+| Tool | Description
|
+| ----------------------- |
-------------------------------------------------------------------------------------------------------------------------------------------------
|
+| `list_charts` | List charts with filtering and search
|
+| `get_chart_info` | Get chart metadata and configuration
|
+| `get_chart_data` | Retrieve chart data (JSON, CSV, or Excel)
|
+| `get_chart_preview` | Generate a chart preview (URL, ASCII, table, or
Vega-Lite)
|
+| `get_chart_type_schema` | Get the configuration schema for a chart type
|
+| `generate_chart` | Create a new chart from a specification (defaults
to preview mode — review before saving)
|
+| `update_chart` | Modify an existing chart's configuration (pass
`generate_preview=False` to persist immediately instead of returning a preview
URL) |
+| `update_chart_preview` | Update a cached chart preview without saving
|
+| `generate_explore_link` | Generate an Explore URL for interactive
visualization
|
+| `delete_chart` | Delete a chart by ID or UUID (soft-deletes to
trash when `SOFT_DELETE` is enabled; returns `permission_denied` if the caller
isn't an editor of the chart — owners, Admins, and explicitly granted editors
qualify) |
### Dashboards
-| Tool | Description
|
-| --------------------------------- |
-------------------------------------------- |
-| `list_dashboards` | List dashboards with filtering and
search |
-| `get_dashboard_info` | Get dashboard metadata and layout
|
-| `generate_dashboard` | Create a new dashboard with specified
charts |
-| `add_chart_to_existing_dashboard` | Add a chart to an existing dashboard
|
+| Tool | Description
|
+| --------------------------------- |
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
+| `list_dashboards` | List dashboards with filtering and
search
|
+| `get_dashboard_info` | Get dashboard metadata and layout
|
+| `generate_dashboard` | Create a new dashboard with specified
charts
|
+| `add_chart_to_existing_dashboard` | Add a chart to an existing dashboard
|
+| `delete_dashboard` | Delete a dashboard by ID, UUID, or slug;
leaves its charts intact (soft-deletes to trash when `SOFT_DELETE` is enabled;
returns `permission_denied` if the caller isn't an editor of the dashboard —
owners, Admins, and explicitly granted editors qualify) |
Review Comment:
A user who can view but not edit a dashboard with an attached alert or
report reaches the reports check before editorship and receives `ReportsExist`
with `permission_denied=false`, so this response contract is not guaranteed.
Could this also describe the attached-report precondition rather than saying
non-editors receive `permission_denied`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
