aminghadersohi commented on PR #43828: URL: https://github.com/apache/superset/pull/43828#issuecomment-5560899600
Addressed every item in the review: - **Bridge-compatible rollout:** added `MCP_STRUCTURED_OUTPUT_ENABLED`, defaulting to `False`. Compatibility mode strips `outputSchema` and `structuredContent` as a pair while retaining text results; enabling the setting passes both through. The setting is wired through HTTP and stdio startup, covered by middleware and real-ASGI protocol tests, and documented in both the MCP configuration guide and `UPDATING.md`. - **Nested `title` field:** schema cleanup removes only string-valued generated annotations, not a `properties.title` subschema. A direct regression test and the `open_sql_lab_with_context` inventory expectation cover this case. - **Output-schema round trips:** reduced-column dashboard and dataset responses plus a not-found error response are explicitly validated with `jsonschema.validate` against the registered tool schema. - **Deprecated stripper:** `StructuredContentStripperMiddleware` is now a real deprecated compatibility subclass that emits `DeprecationWarning` and retains stripping behavior. Its replacement is documented in `UPDATING.md` and the MCP guide. - **Host-only behavior:** added the rationale that extension-owned serializers cannot be assumed to follow the native validation-schema convention. - **Partial schema drift:** added representative full top-level field assertions for dashboard, dataset, SQL Lab, and chart-preview response shapes. No review feedback was declined. The branch was rebased onto `c03f3441bd565b9fd5f082d0b875c467eeae441c` before these edits. Local validation is green: 198 focused tests, 3,729 full MCP unit tests, and the staged pre-commit suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
