aminghadersohi commented on code in PR #43828:
URL: https://github.com/apache/superset/pull/43828#discussion_r3944833643
##########
superset/mcp_service/server.py:
##########
@@ -1035,7 +1040,11 @@ def run_server(
flask_app = get_flask_app()
auth_provider = _create_auth_provider(flask_app)
- middleware_list = build_middleware_list()
+ middleware_list = build_middleware_list(
+ structured_output_enabled=flask_app.config.get(
+ "MCP_STRUCTURED_OUTPUT_ENABLED", MCP_STRUCTURED_OUTPUT_ENABLED
+ )
+ )
Review Comment:
Confirmed: the factory path constructed its FastMCP instance directly and
therefore bypassed the compatibility boundary. It now resolves
`MCP_STRUCTURED_OUTPUT_ENABLED` from the Flask configuration and prepends
`ToolResultCompatibilityMiddleware` before any factory-provided middleware. A
parameterized startup regression test covers both setting values and preserves
custom middleware ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
