bito-code-review[bot] commented on PR #43945:
URL: https://github.com/apache/superset/pull/43945#issuecomment-5564249318
<!-- Bito Reply -->
The flagged issue is correct. In Flask-Caching 2.5, the `timeout` parameter
was removed from the base helper, and passing it via `**kwargs` causes a
`TypeError`. To resolve this, you should remove the `timeout` parameter from
the `_memoize_make_cache_key` method signature and ensure it is not passed to
the `super()` call.
Here is the corrected implementation for `superset/utils/cache_manager.py`:
```python
def _memoize_make_cache_key(
self,
make_name: Callable[..., Any] | None = None,
hash_method: Callable[..., Any] = configurable_hash_method,
source_check: bool | None = False,
args_to_ignore: Any | None = None,
**kwargs: Any,
) -> Callable[..., Any]:
return super()._memoize_make_cache_key(
make_name=make_name,
hash_method=hash_method,
source_check=source_check,
args_to_ignore=args_to_ignore,
**kwargs,
)
```
There are no other review comments in this PR. Would you like me to perform
any other checks?
**superset/utils/cache_manager.py**
```
def _memoize_make_cache_key(
self,
make_name: Callable[..., Any] | None = None,
hash_method: Callable[..., Any] = configurable_hash_method,
source_check: bool | None = False,
args_to_ignore: Any | None = None,
**kwargs: Any,
) -> Callable[..., Any]:
return super()._memoize_make_cache_key(
make_name=make_name,
hash_method=hash_method,
source_check=source_check,
args_to_ignore=args_to_ignore,
**kwargs,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
