sadpandajoe commented on code in PR #43945:
URL: https://github.com/apache/superset/pull/43945#discussion_r3946745054
##########
superset/utils/cache_manager.py:
##########
@@ -147,19 +147,17 @@ def cached(
def _memoize_make_cache_key(
self,
make_name: Callable[..., Any] | None = None,
- timeout: Callable[..., Any] | None = None,
- forced_update: bool = False,
hash_method: Callable[..., Any] = configurable_hash_method,
source_check: bool | None = False,
args_to_ignore: Any | None = None,
+ **kwargs: Any,
) -> Callable[..., Any]:
return super()._memoize_make_cache_key(
make_name=make_name,
- timeout=timeout,
- forced_update=forced_update,
hash_method=hash_method,
source_check=source_check,
args_to_ignore=args_to_ignore,
+ **kwargs,
Review Comment:
The override now forwards unknown options to the 2.5 helper, but
`etag_cache` still calls it with `timeout=timeout` in
`superset/utils/cache.py:327`. Flask-Caching 2.5 rejects that keyword, so any
future `@etag_cache` use fails while decoration builds `make_cache_key`. Should
this call stop passing `timeout`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
