rusackas commented on PR #42849: URL: https://github.com/apache/superset/pull/42849#issuecomment-5563833802
Interesting idea for scoping time grains per dashboard. One thing I'd want changed before this goes further: pulling dashboardInfo.metadata straight out of useContext(ReactReduxContext) + store.getState() instead of useSelector means this won't re-render when that state changes elsewhere, and it's inconsistent with how every other component in `dashboard/` reads Redux state. Worth switching to useSelector like the rest of the codebase. Separately, the branch has conflicts now and lint/pre-commit/docker-build are red, so it'll need a rebase and a clean CI run too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
