rusackas commented on PR #42849: URL: https://github.com/apache/superset/pull/42849#issuecomment-5647690067
Thanks for tackling this! A dashboard-level time grain allowlist is a nice addition on top of the per-filter one. CI's failing on a real TS error though: `dashboardTimeGrainAllowlist.length` on line 114 needs a null check since `time_grain_allowlist` is optional in the schema. Once that's fixed and the pipeline's green I'll take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
