bito-code-review[bot] commented on PR #43946: URL: https://github.com/apache/superset/pull/43946#issuecomment-5575257415
<!-- Bito Reply --> The current implementation of `RENDER_TRIGGER_SHARED_CONTROLS` in `StatefulChart.tsx` is designed to handle string-based control references that cannot be introspected directly. Since `StatefulChart` relies on this static set to determine whether a change should trigger a data refetch, it does not currently account for individual control overrides like `renderTrigger: false` defined in specific chart configurations. To support this, the logic would need to be updated to check the specific control's configuration if available, rather than relying solely on the shared fallback list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
