sadpandajoe commented on code in PR #43946: URL: https://github.com/apache/superset/pull/43946#discussion_r3952406225
########## superset-frontend/packages/superset-ui-core/src/chart/components/StatefulChart.tsx: ########## @@ -50,13 +50,21 @@ type LoadingState = 'uninitialized' | 'loading' | 'loaded' | 'error'; * This list is needed because string-based control references (e.g., ['zoomable']) * cannot be introspected for their renderTrigger property without importing * sharedControls, which would create a circular dependency. + * + * Keep this list in sync with the `renderTrigger: true` entries in + * @superset-ui/chart-controls's sharedControls.tsx. */ const RENDER_TRIGGER_SHARED_CONTROLS = new Set([ 'zoomable', 'color_scheme', 'time_shift_color', 'y_axis_format', 'currency_format', + 'color_picker', + 'linear_color_scheme', Review Comment: This now treats every bare `linear_color_scheme` reference as render-only, but Country Map explicitly overrides that control with `renderTrigger: false`. A Country Map Matrixify cell can therefore keep its old query result when this setting changes. Should `shouldRefetchData` honor control overrides before applying the shared fallback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
