bito-code-review[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3958700146
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
<!-- Bito Reply -->
The suggestion is correct in its assessment that the previous tests relied
on the `isOverflowingFilterBar` logic, which has been removed. Since the
popover now consistently attaches to `document.body`, the tests should be
updated to remove the conditional logic and assert the new behavior directly.
This ensures the test suite remains accurate and passes in the CI environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
