codeant-ai-for-open-source[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3958700902
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag mounting the Date Range filter popover to document.body; this
is intentional to prevent clipping inside the overflow dropdown.
**Applied to:**
-
`superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
