AmoghAtreya commented on PR #42609: URL: https://github.com/apache/superset/pull/42609#issuecomment-5593632413
@rusackas Sorry for the delay! Rebased onto master—the code needed some rework, as you said, since master introduced 'MAX_RESAMPLE_ROWS' in the same spot. I kept master’s 'MAX_RESAMPLE_ROWS' cap while preserving this PR’s calendar-frequency logic (month/quarter/year) that the Timedelta check was bypassing. Apart from that, I rebased all the other files with conflicts to the latest version of master and verified that everything works as intended. Other than that, all the cases are green and should be good for this PR. Please let me know if there's anything else you'd like me to change! The failing Netlify docs preview checks are unrelated to this PR. They stem from an upstream '@ant-design/icons' mismatch that's also present on master, whereas this PR only edits a few lines in exploring-data.mdx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
