rusackas commented on PR #41859: URL: https://github.com/apache/superset/pull/41859#issuecomment-5593888155
Heya @NHanser, this needs a rebase, it's showing conflicts with `master`. Couple of things to look into on CI too: `lint-frontend` is failing a real type error in `test/Timeseries/Bar/controlPanel.test.ts`, `control?.config?.default` doesn't exist on the control's union type there. Looks like that test needs the same `isCustomControlItem` guard the `MixedTimeseries` test already uses. Pre-commit's failing on prettier formatting as well, should be a quick fix. Once CI's green I'm happy to take a closer look at the axis logic itself. Not sure if I can push commits to your fork, but I'll give it a shot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
