rusackas commented on PR #42608: URL: https://github.com/apache/superset/pull/42608#issuecomment-5594979461
This got overtaken by events. #44030 (merged earlier today, the security group bump) took maplibre-gl straight to 6.8.0 on `master`, so both bugs @sadpandajoe flagged here (missing worker wiring, and `preset-chart-deckgl` inheriting root's `maplibre-gl` through `@vis.gl/react-maplibre`) are live on `master` now, not just latent in this PR. I've got a verified fix for the worker piece (CopyPlugin needs to emit the worker plus its sibling `shared.mjs`, and something needs to call `setWorkerUrl` before any map mounts) that belongs on `master` directly at this point rather than here. The version-hoisting one is nastier, npm overrides won't force a split copy since `@vis.gl/react-maplibre` pulls in `maplibre-gl` as a peer dep rather than a regular one, confirmed that across a few clean installs. Might come down to holding `preset-chart-deckgl` back to 5.x again or patch-package. I'd close this in favor of fixing forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
