rusackas commented on PR #42608: URL: https://github.com/apache/superset/pull/42608#issuecomment-5611149502
Rebased this onto current `master`. Worth flagging why the diff looks different now: `master` had drifted past this branch's original target — most notably via #44030 (a grouped dependabot security bump, merged yesterday), which bumped `maplibre-gl` to `^6.8.0` across the frontend, **including `preset-chart-deckgl`**. That's exactly the incompatibility this branch's own commits diagnosed and guarded against: `@deck.gl/mapbox` 9.3.7's terrain-camera path still reads `maplibre-gl`'s internal `map.transform`, which `maplibre-gl` 6 removed. So #44030 silently reintroduced the regression this PR exists to prevent. Since most of this PR's other content (the `react-map-gl` bump, `@types/supercluster`/`@types/geojson`) was already absorbed into `master` independently, the rebased diff is now much smaller — just: - the `DeckGLOverlayMapLibre.test.tsx` + `mapLibreVersionPin.test.ts` test additions, and - one commit re-pinning `preset-chart-deckgl`'s `maplibre-gl` back to `^5.24.0` (resolved as a nested dependency, same mechanism as before) to undo the part of #44030 that broke it. All 407 `preset-chart-deckgl` tests + 78 `plugin-chart-point-cluster-map` tests pass locally, including the `mapLibreVersionPin.test.ts` tripwire. Note for reviewers: **`master` is currently shipping the broken combination** (nothing in CI catches it — both existing deckgl Jest suites mock the real integration), so it'd be worth prioritizing this merge, or cherry-picking just the re-pin commit to `master` directly if that's faster than this PR's normal review cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
