sadpandajoe commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3964552774
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -70,6 +72,9 @@ export default function exportPivotExcel(
logging.error(
`[exportPivotExcel] No element found for selector: "${tableSelector}"`,
);
+ addWarningToast(
Review Comment:
Calling `addWarningToast` here only creates a Redux action object; this
utility has no dispatch and discards it, so the missing-table path still
returns without a user-visible toast. Could this use a dispatch-bound toast
callback (and exercise the rendered toast) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
